Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAL-194-GP-NEW EVENT TRACKING #196

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

gperissetcelteeka
Copy link
Collaborator

NEW EVENT TRACKING

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.
#195

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 4.13%. Comparing base (677cd6c) to head (df4b80c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #196      +/-   ##
========================================
+ Coverage   3.74%   4.13%   +0.39%     
========================================
  Files        133     133              
  Lines      11075   11108      +33     
========================================
+ Hits         414     458      +44     
+ Misses     10661   10650      -11     
Files Coverage Δ
Balance/BalanceAppDelegate.swift 66.67% <57.15%> (-2.08%) ⬇️
Balance/Utils/BalanceExtensions.swift 4.00% <0.00%> (-0.16%) ⬇️
Balance/Balance.swift 77.53% <63.64%> (-4.56%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677cd6c...df4b80c. Read the comment docs.

@gperissetcelteeka gperissetcelteeka enabled auto-merge (squash) May 22, 2024 17:30
Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gperissetcelteeka gperissetcelteeka merged commit f14b097 into main May 22, 2024
5 checks passed
@gperissetcelteeka gperissetcelteeka deleted the feature/BAL-194-NewEvent branch May 22, 2024 21:19
gperissetcelteeka added a commit that referenced this pull request Jun 10, 2024
* main:
  Fix Build Error and Update Codebase (#198)
  BAL-194-GP-NEW EVENT TRACKING (#196)

# Conflicts:
#	Balance.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants