Don't put restored process on foreground if we are background process #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AntonKozlov
reviewed
Aug 7, 2024
Comment on lines
+1068
to
+1070
| if (getppid() != tcgetpgrp(0)) { | ||
| pr_debug("Running in background, not setting foreground process"); | ||
| } else if (root_item->pgid == vpid(root_item)) { |
There was a problem hiding this comment.
Sorry for the delay with reply.
This is not a simple change as it involves the state on checkpoint and the state on restore. So we are not restoring control group if restore runs in background.
- Is it possible that we now leave some states where we should still be foreground? E.g. restoring in subshell like
$ ( ( java -XX:CRaCRestoreFrom= ... ) )
(no &, but parent probably not a foreground?)
-
Can restoring in background negatively impact java process which may assume foreground?
-
If the job moved to foreground (`java -XX:CRaCRestoreFrom= ... & ; fg), does it work correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the restore is executed in background (e.g. using
java -XX:CRaCRestoreFrom=... &) and the restored process receives foreground forcefully, when this exits the parent shell (not on foreground) tries to read input and receives EOF, subsequently exiting. For users this might look as if the bash terminal gets suddenly closed for no reason at all.