Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding COVID Vacination data #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mgithub46
Copy link

Adding COVID vaccination data across different states

Adding COVID Vaccination Data
Adding COVID Vaccination data
Adding COVID Vaccination data
Added extra line as per build verification
@space-buzzer
Copy link
Collaborator

What's the goal of this?
It downloads a file, stores it locally and uploads to spreadsheets? why does it need to run on every single run of this library?

@mgithub46
Copy link
Author

Hi, The goal is to upload COVID vaccination data. It doesn't need to be executed on every run. Could you please let me know your suggestions here.

@space-buzzer
Copy link
Collaborator

space-buzzer commented Jan 3, 2021

Is the goal to download it from an address and upload it, while continuously overriding previous values, to a google spreadsheet?

I just don't understand the need for this nor the method. If the goal is just to store the file, why not just download and store the file?

@mgithub46
Copy link
Author

Once the file is downloaded and updated periodically. It needs to be exposed as an API for the users who are interested in the vaccination data. There is further work which will be done to add it as an API. But as a part of initial work just trying to download the file in the datafetcher.

@space-buzzer
Copy link
Collaborator

I still don't understand the point of this change. What API are you talking about? This project doesn't expose any API.
Is the goal here to make the CSV available in a google spreadsheet? There are Google spreadsheet tools to achieve this, without writing any code.

@mgithub46
Copy link
Author

Hi, The goal is to fetch the most recent covid19 vaccination data from different states, and publish them for easy consumption and use for Covid Tracking Project.

@zachlipton
Copy link
Contributor

This appears to be copying the Johns Hopkins vaccination dataset. I appreciate the contribution, but we're not interested in simply copying their data and putting it into a spreadsheet. Users who are interested in this particular file can get it directly from Johns Hopkins, since they're the ones publishing it and maintaining it. Anyone that needs the CSV in a regularly-updated spreadsheet that overwrites the past data, can do that directly with Google Sheet's IMPORTDATA built-in.

@space-buzzer
Copy link
Collaborator

This project does not feed the Covid Tracking Project API.
If you want to make suggestions about additions to the API, you can use the Issues repo and post your issue there, together with the relevant links and explain what is it that you'd want to accomplish.
I do not know whether there are plans to provide vaccine info through the API.

@mgithub46
Copy link
Author

Thanks a lot to both of you Gentlemen. Please let me know if I could contribute in any way to datafetcher repo. Either through resolving issues or making changes to existing code. Would be more than happy to contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants