Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New exporter: go #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sschleemilch
Copy link
Collaborator

@sschleemilch sschleemilch commented Sep 16, 2024

Added new generator: go

It does produce structs to work with the vss tree.

It only produces simple structs for now. In future, we can also generate get/set methods and use the allowed as well as min/max fields.

@erikbosch
Copy link
Collaborator

Could you possibly add a README in https://github.com/COVESA/vss-tools/tree/master/docs that gives a bit on background and how the tool can be used or is intended to be used. Like linking to https://go.dev/ as possible not every one is familiar with Go.

We use Go in https://github.com/COVESA/vissr and I am curious if what we have here could be a replacement to the "binary" format currently used by that tool. ideas @UlfBj ?

@sschleemilch
Copy link
Collaborator Author

Could you possibly add a README in https://github.com/COVESA/vss-tools/tree/master/docs that gives a bit on background and how the tool can be used or is intended to be used. Like linking to https://go.dev/ as possible not every one is familiar with Go.

We use Go in https://github.com/COVESA/vissr and I am curious if what we have here could be a replacement to the "binary" format currently used by that tool. ideas @UlfBj ?

Done. Added README: https://github.com/sschleemilch/vss-tools/blob/feature/go-exporter/docs/go.md

@sschleemilch
Copy link
Collaborator Author

Lets not merge it yet. I would like to make some improvements.

@erikbosch
Copy link
Collaborator

MoM:

  • Erik: Not planned for 5.0
  • Ulf: Did a quick review, this one generates structs, slightly different scope compared to binary format, which is language agnostic, so not a replacement for binary
  • Erik: Good if @UlfBj checks that code follows "good Go practice"
  • Ulf: I can do it
  • Please review

@UlfBj
Copy link
Contributor

UlfBj commented Sep 19, 2024

It looks good to me.

Signed-off-by: Sebastian Schleemilch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants