-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update exporters to export static UIDs if available #373
Conversation
f031077
to
5295c89
Compare
Would this be valid
|
c90a68c
to
633ffcb
Compare
MoM: Let's have a look.. We need time to review this. |
5d0640a
to
e5b8b0e
Compare
hi @erikbosch, do you have any info on the (dds)idl exporter? could you take a quick look at my comment above? Maybe you have an idea how to add attributes to branches in idl files? For me there is no way to check if my implementation is correct as I can't get the Edit: In case you are not that familiar with the (dds)idl related code maybe there is somebody else in covesa that is? |
I do not think that anyone has worked on DDSIDL lately. I do not think the structs support
I created a simple test case in #379 to update instructions, they seemed to be mashed up. Also a simple test case to verify that output is accepted. I honestly do not know if the ddsidl generator is useful as of today, or if it rather should be deprecated. |
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
…D a core attribute Signed-off-by: Niclas Wesemann <[email protected]>
franca exporter now exports staticUID if available Signed-off-by: Niclas Wesemann <[email protected]>
such that it exports static UIDs if available Signed-off-by: Niclas Wesemann <[email protected]>
such that it exports static UID if available Signed-off-by: Niclas Wesemann <[email protected]>
such that it exports staticUID if available Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]> fix binary exporter and parser now working including staticUIDs if available Signed-off-by: Niclas Wesemann <[email protected]>
such that it exports staticUID if available Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
…staticUID a core attribute" This reverts commit 86d9587. Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
such that it exports staticUID if available Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
8cc5659
to
5c40468
Compare
Signed-off-by: Niclas Wesemann <[email protected]>
Signed-off-by: Niclas Wesemann <[email protected]>
@@ -24,13 +24,17 @@ | |||
# Write the header line | |||
|
|||
|
|||
def print_csv_header(file, uuid, entry_type: AnyStr, include_instance_column: bool): | |||
def print_csv_header(file, uuid, entry_type: AnyStr, include_instance_column: bool, extended_arrtributes: dict = {}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo arrtributes
Conflicts! Also added @UlfBj as reviewer as it concerns the "binary" tool quite a lot. Ulf - could you check how much implications this would have for VISSR. As it is for a major VSS(tools) release I guess that some required changes in VISSR is acceptable. |
Yes I already rebased once will do it again later today |
@nwesem - still conflicts |
MoM:
|
To be reopened when needed |
Changes:
How to verify:
First you have to create an ID file with
Now we check all exporters:
If you want to test that it still works without staticUIDs: