follow up to #30 #31
Open
follow up to #30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #30 i noticed that sometimes clang will
realpathit's files.Eg TSAN uses llvm-symbolizer and will resolve symbolic-links when doing so.
This can cause mangled file names to be shown in autotest output.
This PR reverts
link_program()to use hard-links.But adds additional checks to ensure that the previous issues don't return:
Firstly
link_program()now compares inode numbers instead of usingos.path.islink()Secondly a new function
unlink_program()function is added to remove any hard-links thatlink_program()creates.This is once again because of the
os.rename()inrun_compilers()