Skip to content

Commit

Permalink
feat: add timeout
Browse files Browse the repository at this point in the history
Add a timeout for the requests.
  • Loading branch information
CMiksche committed Sep 4, 2022
1 parent 6f85b5b commit 8b30f0b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
[![PyPI version](https://badge.fury.io/py/gitea-auto-update.svg)](https://badge.fury.io/py/gitea-auto-update)
[![Downloads](https://pepy.tech/badge/gitea-auto-update)](https://pepy.tech/project/gitea-auto-update)
![GitHub](https://img.shields.io/github/license/cmiksche/gitea-auto-update?style=flat)
![Twitter Follow](https://img.shields.io/twitter/follow/cmiksche?style=social)
[![Twitter Follow](https://img.shields.io/twitter/follow/cmiksche?style=social)](https://twitter.com/cmiksche)
[![Mastodon Follow](https://img.shields.io/mastodon/follow/106336578279256330?domain=https%3A%2F%2Fmastodon.social&style=social)](https://mastodon.social/@cmiksche)

Script for a automatic update of gitea. Should be run locally on the gitea server. Has options for updating via new binary file or build from source.
Script for an automatic update of gitea. Should be run locally on the gitea server. Has options for updating via new binary file or build from source.

## Procedure
* Get Gitea Version from the Gitea CLI and if that fails from the Gitea API
Expand Down
2 changes: 1 addition & 1 deletion gitea_auto_update/lib/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def download(url, file_name):
# open in binary mode
with open(file_name, "wb") as file:
# get request
response = requests.get(url)
response = requests.get(url, timeout=3600)
# write to file
file.write(response.content)

Expand Down
4 changes: 2 additions & 2 deletions gitea_auto_update/lib/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

def get_github_version_tag(api_url):
"""Get the version from github"""
version_tag = requests.get(api_url).json()['tag_name']
version_tag = requests.get(api_url, timeout=30).json()['tag_name']
logging.info('Version: github_version_tag = %s', version_tag)
return version_tag

Expand Down Expand Up @@ -49,7 +49,7 @@ def get_current_version(self):
except IOError:
# Get the version via the web api if the file does fail
try:
current_version = requests.get(self.gt_site).json()['version']
current_version = requests.get(self.gt_site, timeout=30).json()['version']
if current_version.status_code != 200:
raise RuntimeError("Could not download version.") from None
except RuntimeError:
Expand Down

0 comments on commit 8b30f0b

Please sign in to comment.