US9 - Change theme path to avoid linter error #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
ilong4rennes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changed the theme repo path from a local file reference to the original version in install/package.json.
Why
The last PR failed lint due to theme errors caused by the following issue:
Error: ENOENT: no such file or directory, open '/home/runner/work/nodebb-f24-the-turtles/nodebb-f24-the-turtles/node_modules/nodebb-theme-harmony/theme.json'.This was caused by modifying the front-end theme dependency in package.json to link a local repository:
"nodebb-theme-harmony": "file:../nodebb-frontend-f24-the-turtles"Linking to a local repository bypassed the usual npm installation process, which ensures all required files, like
theme.json, are present. This PR corrects that by reverting to the original theme version.How
Updated the nodebb-theme-harmony path in install/package.json.
Testing
No testing needed due to the nature of this change.