Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register.json - user story 7 #18

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Update register.json - user story 7 #18

merged 7 commits into from
Sep 21, 2024

Conversation

e5z26
Copy link

@e5z26 e5z26 commented Sep 21, 2024

Added attributes in register.json (en-US) located in public/language for front end to call on the register page. Attributes are fullname and fullname-placeholder to use when creating full name area on register page. Below shows that the attributes do with the text of "Full Name" and "Enter Full Name".
Screenshot 2024-09-20 at 20 17 15

Added to register.json (en-US version) attributes called "fullname" and "fullname-placeholder" to be used in the frontend part of NodeBB
Your Name added 2 commits September 20, 2024 20:35
Adding authentication for the fullname and throwing an error if the user didn't type in anything for the full name while they are registering
@coveralls
Copy link

coveralls commented Sep 21, 2024

Pull Request Test Coverage Report for Build 10975954736

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.672%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10966009242: -0.005%
Covered Lines: 22327
Relevant Lines: 25587

💛 - Coveralls

Your Name and others added 4 commits September 20, 2024 20:43
…ebb-f24-team-five-guys into user-story-7"

This reverts commit f55fd69, reversing
changes made to 2da747e.
Add full name entry box at front-end so that users can enter their full name while registering
@paulinezhanghh paulinezhanghh merged commit e57c350 into f24 Sep 21, 2024
1 check passed
@paulinezhanghh paulinezhanghh deleted the user-story-7 branch September 21, 2024 22:02
@paulinezhanghh paulinezhanghh restored the user-story-7 branch September 21, 2024 22:02
@paulinezhanghh paulinezhanghh deleted the user-story-7 branch September 21, 2024 22:02
@LeeMEow23 LeeMEow23 self-requested a review September 23, 2024 15:52
@LeeMEow23 LeeMEow23 added the enhancement New feature or request label Oct 6, 2024
@LeeMEow23 LeeMEow23 added this to the Sprint 1 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants