Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed complexity issues of src/notifications.js #560

Open
wants to merge 3 commits into
base: f24
Choose a base branch
from

Conversation

LastSymphony12
Copy link

Reduced two blocks of code: Notifications.forEach and Differentiators.forEach. These functions have been passed through the lint and test functions, resulting in no errors and 87.06% coverage respectively.
Console Log Testing wasn’t possible, as my local system was unable to run those.
This is related to issue #297

Copy link

sonarcloud bot commented Sep 5, 2024

@coveralls
Copy link

coveralls commented Sep 5, 2024

Pull Request Test Coverage Report for Build 11506334754

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 82.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/notifications.js 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10607818019: 0.007%
Covered Lines: 22325
Relevant Lines: 25584

💛 - Coveralls

Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants