Static linking with MSVC and PRECOMPILED=ON

[timkruse]

Solves the following issue:

Using CLI11 with the option CLI11_PRECOMPILED=ON results in the following linking error (Windows10 + MSVC set up to link statically)

CLI11.lib(Precompile.cpp.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in srcfile.cpp.obj

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4ee3af) to head (d6e26ee).
Report is 35 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##              main     #1066    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17        17            
  Lines         4546      4583    +37     
  Branches         0       983   +983     
==========================================
+ Hits          4546      4583    +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[phlptp]

what would a CI build look like that would have caught this error?

[timkruse]

Changing my application that includes CLI11 back to dynamic linking brings back the linking error from above but with swapped MD_DynamicRelease and MT_StaticRelease. So this PR is pointless, sorry.

For documentation purposes:
I want a statically linked executable on Windows with MSVC and use CLI11_PRECOMPILED=ON. Therefore, I have to put

set_property(TARGET myApp PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

in my CMakeLists.txt. That line alone raises the linking error shown above. To fix it CLI11 needs to be compiled with the same MSVC_RUNTIME_LIBRARY flags, but it can be placed in my CMakeLists.txt, too:

set_property(TARGET CLI11 PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

[phlptp]

I have vague recollections of having something like this in another library, I will poke around and see if anything should be done differently to make it a little smoother.