Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joyce Chen Lab 2 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Joyce Chen Lab 2 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
# lab02-debugging
Team: Joyce Chen, Katherine Li

# Setup
https://www.shadertoy.com/view/MXfcW2

Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc).

Let's practice debugging! We have a broken shader. It should produce output that looks like this:
[Unbelievably beautiful shader](https://user-images.githubusercontent.com/1758825/200729570-8e10a37a-345d-4aff-8eff-6baf54a32a40.webm)

It don't do that. Correct THREE of the FIVE bugs that are messing up the output. You are STRONGLY ENCOURAGED to work with a partner and pair program to force you to talk about your debugging thought process out loud.

Extra credit if you can find all FIVE bugs.

# Submission
- Create a pull request to this repository
- In the README, include the names of both your team members
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)
1. “vec2 uv2 = 2.0 * uv - vec2(1.0);” changed vec to vec2 in mainImage, noticed syntax error noted by shader toy,
2. “H *= len * iResolution.x / iResolution.y;” noticed H was calculated by len * iResolution.x / iResolution.x, which probably isn’t right
3. “raycast(uv2, dir, eye, ref);”reading comments, noticed that raycast function takes in uv [0,1] coords instead of uv2 [-1,1] coords
4. “dir = reflect(dir, nor);”changed argument taken in by reflect from eye to dir, found by reading through sdf3D function and finding that reflect needs incident ray direction, not camera position
5. “for(int i = 0; i < 200; ++i) {”increased march iterations from 64 to 200, noticed scene render difference between example and my scene