-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1주차] 최지원 미션 제출합니다. #3
base: master
Are you sure you want to change the base?
Changes from 1 commit
2174809
3556734
1434121
8ec025d
e3313a3
a254567
3152ab0
4de67aa
8f7e29b
c08b6fa
86260ea
3d0989b
ca4e76e
3d044fe
28d46e6
970222b
cd12e36
780ce6d
a8f23ca
eb9f93e
9ef7e0e
f6d8336
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,27 +13,35 @@ | |
<h1 class="today"></h1> | ||
</header> | ||
<nav class="box-style"> | ||
<span class="intro ment-style">당신의 할 일을 작성해보세요 ✏️</span> | ||
<button class="showInput ment-style">입력창 불러오기</button> | ||
<span class="ment-style">당신의 할 일을 작성해보세요 ✏️</span> | ||
<button class="show-input ment-style">입력창 불러오기</button> | ||
</nav> | ||
|
||
<main class="contents box-style"> | ||
<main class="box-style"> | ||
<section class="todo"> | ||
<div class="todoTop"> | ||
<div class="todo-top"> | ||
<h2 class="ment-style">What I have to do</h2> | ||
<form class="inputBox box-style"> | ||
<form class="input-box box-style"> | ||
<input class="input" /> | ||
<button class="submitBtn">작성하기</button> | ||
<button class="submit-btn">작성하기</button> | ||
</form> | ||
</div> | ||
<ul class="todoList"></ul> | ||
</section> | ||
|
||
<section class="did"> | ||
<h2 class="ment-style">What I did</h2> | ||
<ul class="didList"></ul> | ||
</section> | ||
</main> | ||
<footer> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. footer main 등등 시맨틱 태그들을 적절히 잘 활용해주셨네요!! 문서의 구조를 보다 더 명확하게 파악할 수 있는 것 같습니다 ㅎㅎ |
||
<span> | ||
<span class="today"><b>T</b>otal: </span> | ||
<span class="count"></span> | ||
</span> | ||
<span> | ||
<span class="today"> <b>A</b>ccomplishment: </span> | ||
<span class="accomplishment"></span> | ||
</span> | ||
</footer> | ||
</div> | ||
</body> | ||
<script src="script.js"></script> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,14 +5,14 @@ body { | |
|
||
.container { | ||
width: 100%; | ||
max-width: 600px; | ||
max-width: 37.5rem; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rem단위로 css를 사용하시는군요! 혹시 픽셀이나 다른 단위가 아닌 rem으로 했을 때의 장단점이나 이유가 있는지 여쭤보고 싶습니다! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
height: 100%; | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
} | ||
|
||
@media screen and (max-width: 1000px) { | ||
@media screen and (max-width: 62.5rem) { | ||
.container { | ||
width: 80%; | ||
} | ||
|
@@ -28,71 +28,81 @@ header { | |
color: #85b6ff; | ||
font-family: "Pretendard"; | ||
font-weight: 300; | ||
font-size: 15px; | ||
font-size: 0.938rem; | ||
} | ||
|
||
nav { | ||
width: 100%; | ||
height: 50px; | ||
height: 3.125rem; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
padding: 0 20px; | ||
margin-bottom: 20px; | ||
padding: 0 1.25rem; | ||
margin-bottom: 1.25rem; | ||
} | ||
|
||
main { | ||
width: 100%; | ||
display: flex; | ||
flex-direction: column; | ||
padding: 20px; | ||
padding: 0.625rem 1.25rem; | ||
} | ||
|
||
button { | ||
border: none; | ||
background-color: transparent; | ||
} | ||
|
||
.todoTop { | ||
.todo-top { | ||
display: flex; | ||
flex-direction: row; | ||
align-items: center; | ||
justify-content: space-between; | ||
} | ||
|
||
.inputBox { | ||
.input-box { | ||
width: 50%; | ||
height: 30px; | ||
height: 1.875rem; | ||
display: flex; | ||
flex-direction: row; | ||
align-items: center; | ||
justify-content: space-between; | ||
padding: 0 10px; | ||
padding: 0 0.625rem; | ||
} | ||
|
||
input { | ||
width: 30%; | ||
width: 70%; | ||
border: transparent; | ||
font-family: "Pretendard"; | ||
} | ||
|
||
.submitBtn { | ||
input:focus { | ||
outline: none; | ||
} | ||
|
||
@media screen and (max-width: 41.875rem) { | ||
input { | ||
width: 60%; | ||
} | ||
} | ||
|
||
button { | ||
border: none; | ||
background-color: transparent; | ||
} | ||
|
||
.submit-btn { | ||
color: #85b6ff; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #85b6ff,#458fff 이 두 색상을 계속해서 사용해주셨는데, 공식 문서에 나와있듯이, :root 클래스에 선언해서 HTML 문서 전체에서 이를 활용할 수 있도록 할 수 있으니 한 번 참고해보시면 좋을 것 같습니다! :root { ... |
||
font-family: "Pretendard"; | ||
font-weight: 600; | ||
font-size: 18px; | ||
font-size: 0.938rem; | ||
} | ||
|
||
.ment-style { | ||
color: #458fff; | ||
font-family: "Pretendard"; | ||
font-weight: 600; | ||
font-size: 18px; | ||
font-size: 1.125rem; | ||
} | ||
|
||
.box-style { | ||
border-radius: 30px; | ||
border: 1px solid #85b6ff; | ||
border-radius: 1.875rem; | ||
border: 0.063rem solid #85b6ff; | ||
} | ||
|
||
ul li { | ||
|
@@ -105,24 +115,35 @@ ul { | |
padding-left: 0; | ||
} | ||
|
||
footer { | ||
width: 12.5rem; | ||
display: flex; | ||
flex-direction: row; | ||
justify-content: space-between; | ||
align-self: flex-start; | ||
} | ||
|
||
/*todo 항목 스타일*/ | ||
|
||
.todo-item { | ||
display: flex; | ||
align-items: center; | ||
margin-bottom: 15px; | ||
margin-bottom: 0.938rem; | ||
} | ||
|
||
.todo-text, | ||
.did-text { | ||
color: #458fff; | ||
font-family: "Pretendard"; | ||
font-weight: 300; | ||
font-size: 16px; | ||
font-size: 1rem; | ||
} | ||
|
||
.todo-check img { | ||
width: 20px; | ||
width: 1.25rem; | ||
} | ||
|
||
.todo-del img { | ||
width: 12px; | ||
height: 0.688rem; | ||
padding-bottom: 0.125rem; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이콘과 로고 같은 경우에는 png, jpeg 보다는 SVG 형식을 쓰는게 좋아요! SVG 형식은 벡터 기반이기 때문에 크기가 조절되어도 이미지 품질이 손상되지 않기 때문에 유연한 크기 조절이 가능한 SVG 형식이 아이콘과 로고 같은 작은 이미지에 적합합니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 delete 아이콘이 같은 로직을 통해 생성되는데도 어떤 건 약간 가로로 길쭉한 .. 현상이 있었어서 width, height, 그걸 감싸는 별도의 태그 추가 등 크기 관련 코드만 여러 번 고쳐보았었는데 svg로 바꿔보아야겠다는 생각은 못했네요..! 첨부해주신 표 덕분에 정확히 알아가서 쓸 수 있을 것 같아요☺️