-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1주차] 최지원 미션 제출합니다. #3
Open
jiwonnchoi
wants to merge
22
commits into
CEOS-Developers:master
Choose a base branch
from
jiwonnchoi:jiwonnchoi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2174809
feat: 기본 UI 구현
jiwonnchoi 3556734
feat: 입력창 토글 기능 구현
jiwonnchoi 1434121
feat: 할 일 추가 함수 구현
jiwonnchoi 8ec025d
feat: 토글, 삭제 함수 구현
jiwonnchoi e3313a3
feat: 날짜 및 현재시각 표기
jiwonnchoi a254567
feat: 로컬스토리지 데이터 처리 구현
jiwonnchoi 3152ab0
feat: 반응형 구현
jiwonnchoi 4de67aa
style: 클래스명 수정 및 rem 단위 변환
jiwonnchoi 8f7e29b
feat: 공통 기능 함수화
jiwonnchoi c08b6fa
feat: 전체, 완료된 항목 개수 표기 추가
jiwonnchoi 86260ea
feat: 입력창 애니메이션 추가
jiwonnchoi 3d0989b
fix: 스타일 수정 및 주석 추가
jiwonnchoi ca4e76e
chore: 버셀 배포
jiwonnchoi 3d044fe
refactor: 아이콘 png에서 svg로 변경
jiwonnchoi 28d46e6
refactor: 현재시각 1초지연 방지
jiwonnchoi 970222b
refactor: did 네이밍 done으로 변경
jiwonnchoi cd12e36
refactor: addTodoItem의 input값 캐싱
jiwonnchoi 780ce6d
refactor: deleteItem 중복호출 수정
jiwonnchoi a8f23ca
refactor: 전역 스타일 추가
jiwonnchoi eb9f93e
refactor: toggleForm 로직 분리 및 불리언 추가
jiwonnchoi 9ef7e0e
refactor: 버튼생성 이벤트를 상위에 위임하도록 수정
jiwonnchoi f6d8336
fix: 배열 각 항목에 고유id 추가
jiwonnchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,65 @@ | ||
/* 본인의 디자인 감각을 최대한 발휘해주세요! */ | ||
.container { | ||
width: 100%; | ||
height: 100%; | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
} | ||
|
||
.nav { | ||
width: 600px; | ||
height: 50px; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
padding: 0 20px; | ||
margin-bottom: 20px; | ||
} | ||
|
||
.contents { | ||
width: 600px; | ||
display: flex; | ||
flex-direction: column; | ||
padding: 20px; | ||
} | ||
|
||
.todoTop { | ||
display: flex; | ||
flex-direction: row; | ||
align-items: center; | ||
justify-content: space-between; | ||
} | ||
|
||
.inputBox { | ||
width: 300px; | ||
height: 30px; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
padding: 0 10px; | ||
} | ||
|
||
.input { | ||
width: 70%; | ||
border: transparent; | ||
} | ||
|
||
.submitBtn { | ||
color: #85b6ff; | ||
font-family: "Pretendard"; | ||
font-weight: 600; | ||
font-size: 18px; | ||
} | ||
|
||
.mentStyle { | ||
color: #458fff; | ||
font-family: "Pretendard"; | ||
font-weight: 600; | ||
font-size: 18px; | ||
} | ||
|
||
.boxStyle { | ||
border-radius: 30px; | ||
border: 1px solid #85b6ff; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#85b6ff,#458fff 이 두 색상을 계속해서 사용해주셨는데,
재사용되는 색상을 CSS 전역 변수로 정의해서 이용하는 방법을 제안드려요!
공식 문서에 나와있듯이, :root 클래스에 선언해서 HTML 문서 전체에서 이를 활용할 수 있도록 할 수 있으니 한 번 참고해보시면 좋을 것 같습니다!
https://developer.mozilla.org/ko/docs/Web/CSS/Using_CSS_custom_properties
:root {
--primary-color: #85b6ff;
--secondary-color: #458fff;
}
...
.today {
color: var(--primary-color);
font-family: "Pretendard";
font-weight: 300;
font-size: 0.938rem;
}
...