Skip to content

Commit

Permalink
Fixes from review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
CBroz1 committed Oct 12, 2023
1 parent fa3a033 commit 3ed2b03
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/spyglass/common/common_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ class Probe(dj.Manual):
probe_id: varchar(80) # a unique ID for this probe & dynamic config
---
-> ProbeType # Type of probe, selected from a controlled list
-> [nullable] DataAcquisitionDevice # the data actwquisition device used
-> [nullable] DataAcquisitionDevice # the data acquisition device used
contact_side_numbering: enum("True", "False") # Facing you when numbering
"""

Expand Down
16 changes: 8 additions & 8 deletions src/spyglass/common/common_filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ class FirFilterParameters(dj.Manual):
filter_sampling_rate: int # sampling rate for this filter
---
filter_type: enum("lowpass", "highpass", "bandpass")
filter_low_stop = 0: float # lowest freq for stop band for low filt
filter_low_pass = 0: float # lowest freq for pass band of low filt
filter_high_pass = 0: float # hi'est freq for pass band for high filt
filter_high_stop = 0: float # hi'est freq for stop band of high filt
filter_comments: varchar(2000) # comments about the filter
filter_band_edges: blob # numpy array of filter bands
# redundant with individual parameters
filter_coeff: longblob # numpy array of filter coefficients
filter_low_stop = 0: float # lowest freq for stop band for low filt
filter_low_pass = 0: float # lowest freq for pass band of low filt
filter_high_pass = 0: float # highest freq for pass band for high filt
filter_high_stop = 0: float # highest freq for stop band of high filt
filter_comments: varchar(2000) # comments about the filter
filter_band_edges: blob # numpy array of filter bands
# redundant with individual parameters
filter_coeff: longblob # numpy array of filter coefficients
"""

def add_filter(
Expand Down

0 comments on commit 3ed2b03

Please sign in to comment.