-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton service incorporation into CAVEclient is working, at least in certain respects #212
Conversation
…into skeleton_dev
A few comments:
|
Looking at the endpoints that are available, I wonder if it wouldn't make sense to add something like:
I also wonder if there shouldn't be a multithreaded bulk download function. |
Also note that there are currently are some linting errors. |
Saving for another day. I'd like to wrap up this PR for now. |
… much hard to visually comprehend. Is this really what we want?
I object to the lint tests requiring ruff formatting that butchers the code and requires us to work with a visual morass instead of formatting code in a way that is easier to visually comprehend and understand. |
I'd like to merge these CAVEclient changes in but would definitely appreciate others looking it all over to make sure it doesn't look like it would break anything important.