Skip to content

Commit

Permalink
Remove MaterializationClient factory (#229)
Browse files Browse the repository at this point in the history
* remove factory

* possible smarter versioning

* attempt tables merge

* attempt views merge

* refactor live_live_query
  • Loading branch information
bdpedigo authored Sep 17, 2024
1 parent e4f4ef5 commit 522caf3
Show file tree
Hide file tree
Showing 3 changed files with 110 additions and 381 deletions.
5 changes: 4 additions & 1 deletion caveclient/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,10 @@ def server_version(self) -> Optional[Version]:
"""The version of the service running on the remote server. Note that this
refers to the software running on the server and has nothing to do with the
version of the datastack itself."""
return self._server_version
if self._server_version is None and self._api_version is not None:
return Version(str(self._api_version))
else:
return self._server_version

@staticmethod
def raise_for_status(r, log_warning=True):
Expand Down
4 changes: 2 additions & 2 deletions caveclient/frameworkclient.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from .infoservice import InfoServiceClient
from .jsonservice import JSONService
from .l2cache import L2CacheClient
from .materializationengine import MaterializationClient, MaterializationClientType
from .materializationengine import MaterializationClient
from .skeletonservice import SkeletonClient


Expand Down Expand Up @@ -515,7 +515,7 @@ def annotation(self) -> AnnotationClient:
return self._annotation

@property
def materialize(self) -> MaterializationClientType:
def materialize(self) -> MaterializationClient:
"""
A client for the materialization service. See [client.materialize](../client_api/materialize.md)
for more information.
Expand Down
Loading

0 comments on commit 522caf3

Please sign in to comment.