Add install_dir option #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 63.84% 63.95% +0.10%
==========================================
Files 35 35
Lines 2597 2616 +19
==========================================
+ Hits 1658 1673 +15
- Misses 939 943 +4 ☔ View full report in Codecov by Sentry. |
SeanBryan51
force-pushed
the
259-option-for-specifying-the-location-of-installed-executables
branch
from
d6d6eb5
to
dc5c0a7
Compare
SeanBryan51
force-pushed
the
259-option-for-specifying-the-location-of-installed-executables
branch
from
dc5c0a7
to
0afa73f
Compare
SeanBryan51
force-pushed
the
259-option-for-specifying-the-location-of-installed-executables
branch
from
0afa73f
to
51591e0
Compare
SeanBryan51
requested review from
a team and
bschroeter
and removed request for
a team
|
Integration tests are passing. I've also tested the new functionality with a version of CABLE built using CMake which requires setting |
SeanBryan51
added
priority:high
bschroeter
approved these changes
Mar 21, 2024
SeanBryan51
deleted the
259-option-for-specifying-the-location-of-installed-executables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently benchcab assumes the compiled executables are installed under the src/offline directory, however this may not always be the case (e.g. this script installs binaries under
<project_root>/bin). This change adds theinstall_diroption which lets the user specify the directory in which benchcab can find the built executables.Fixes #259