-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project
keyword improvements in config.yml
#232
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 59.13% 59.65% +0.51%
==========================================
Files 29 30 +1
Lines 2129 2191 +62
==========================================
+ Hits 1259 1307 +48
- Misses 870 884 +14 ☔ View full report in Codecov by Sentry. |
@ccarouge @SeanBryan51 right now the CI test is failing due to not having
|
Ok so for now I've created a mock test environment variable within the |
project
keyword optional in config.yml
project
keyword optional in config.yml
project
keyword optional in config.yml
project
keyword in config.yml
project
keyword in config.yml
project
keyword improvements in config.yml
9daf322
to
3ec5d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not approving simply because I have a question about the ordering of the validation and setting the default values of optional keys.
The other changes are quite simple.
28779b5
to
45630e8
Compare
Make `project` keyword optional in `config.yml` Improve documentation for config Move checks for optional project keyword, add documentation and tests Add tests for optional project key Remove comment for adding validation checks for project and move to another issue
45630e8
to
e3f1f9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Fixes #231 , #246
Merge Message
project
keyword, use the corresponding value as ID, otherwise use$PROJECT
.config
module.