Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organise unit tests to use pytest fixtures (test_config.py implementation) #177

Conversation

SeanBryan51
Copy link
Collaborator

No description provided.

@SeanBryan51
Copy link
Collaborator Author

This change was very painful. Hopefully once #143 is implemented we can remove these tests completely!

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #177 (226b821) into 163-tidy-up-organisation-of-unit-tests (b3a0fac) will increase coverage by 15.17%.
The diff coverage is 100.00%.

@@                             Coverage Diff                             @@
##           163-tidy-up-organisation-of-unit-tests     #177       +/-   ##
===========================================================================
+ Coverage                                   60.45%   75.63%   +15.17%     
===========================================================================
  Files                                          25       25               
  Lines                                        1659     1658        -1     
===========================================================================
+ Hits                                         1003     1254      +251     
+ Misses                                        656      404      -252     
Files Coverage Δ
tests/test_config.py 100.00% <100.00%> (+98.24%) ⬆️

... and 1 file with indirect coverage changes

@bschroeter
Copy link
Collaborator

This change was very painful. Hopefully once #143 is implemented we can remove these tests completely!

Indeed!

Copy link
Collaborator

@bschroeter bschroeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to make way for #143 shortly.

@SeanBryan51 SeanBryan51 merged commit c03e814 into 163-tidy-up-organisation-of-unit-tests Oct 12, 2023
4 checks passed
@SeanBryan51 SeanBryan51 deleted the 163-tidy-up-organisation-of-unit-tests-test_config branch October 12, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants