Internal code review request #2
Conversation
…erted Metro M4 Express board configurations to original
…ld scripts to build firmware for rapid0 boards, updated peripherals submodule
There was a problem hiding this comment.
was this being done for a test? i went to compare to adafruit circuitpy 9.0.3 and it has the i2ctarget line
There was a problem hiding this comment.
we don't want this to be merged to main
There was a problem hiding this comment.
will remove in merge commit
There was a problem hiding this comment.
do we want to merge our custom build scripts to main? we don't want to merge it to adafruit, and we aren't even using it anymore
There was a problem hiding this comment.
will remove in merge commit
There was a problem hiding this comment.
(same comment as mac script, also should remove the "build-samd51-interpreter" and "build-samd51-interpreter-mac" scripts on main)
There was a problem hiding this comment.
will remove in merge commit
| @@ -199,11 +145,9 @@ void common_hal_busio_spi_construct(busio_spi_obj_t *self, | |||
| // Pads must be set after spi_m_sync_init(), which uses default values from | |||
| // the prototypical SERCOM. | |||
|
|
|||
| hri_sercomspi_write_CTRLA_MODE_bf(sercom, slave_mode ? 2 : 3); | |||
| self->slave_mode = slave_mode; | |||
| hri_sercomspi_write_CTRLA_MODE_bf(sercom, 3); | |||
There was a problem hiding this comment.
this seems left over from the former peripheral mode implementation in SPI.c. also it seems like SPI.c includes the async spi stuff that adafruit doesnt want so we shouldn't merge it onto main (unless i misunderstood our repo design and you are going to cherry pick changes from our main to merge onto their's but that seems unideal)
No description provided.