Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update dependency versions #19

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Chore: update dependency versions #19

merged 5 commits into from
Jul 19, 2023

Conversation

digicosmos86
Copy link
Contributor

@digicosmos86 digicosmos86 commented Jul 6, 2023 •
edited
Loading

Updates in this PR are:

  • Upped versions of terraform, ruby, all modules used, pre-commit checks and github actions.
  • Added tfsec:ignore rules to main.tf to work around its complaints.
  • Removed skip_privisioner input parameter and variable because it's no longer supported.
  • Updated kitchen tests to account for changes to custom service accounts.

@digicosmos86 digicosmos86 linked an issue Jul 6, 2023 that may be closed by this pull request
Update for 2023 #18
Closed
@github-actions github-actions bot added the chore label Jul 6, 2023
@digicosmos86 digicosmos86 linked an issue Jul 8, 2023 that may be closed by this pull request
Default OAuth Scopes have changed and tests fail #17
Closed
mirestrepo
mirestrepo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mirestrepo mirestrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much!

@digicosmos86 digicosmos86 merged commit c6b2df2 into main Jul 19, 2023
3 checks passed
@digicosmos86 digicosmos86 deleted the chore-update-2023 branch July 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirestrepo mirestrepo mirestrepo approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for 2023 Default OAuth Scopes have changed and tests fail
2 participants
@digicosmos86 @mirestrepo