Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: upgrade to Lit 3 #52

Merged
merged 1 commit into from
May 21, 2024
Merged

BREAKING CHANGE: upgrade to Lit 3 #52

merged 1 commit into from
May 21, 2024

Conversation

dlockhart
Copy link
Contributor

@dlockhart dlockhart commented May 3, 2024

Note: this repo is only used by the media player... it would save a lot of effort in the long run if it could be merged into that repo at some point!

⚠️ DO NOT MERGE yet! ⚠️

👋 Hey, we're upgrading to Lit 3! 🎉 This PR prepares this repo for the upgrade, which will happen starting May 21st. Someone from team Gaudí will take care of everything (except approving this PR), so sit back and enjoy the upgrade!

A Phased Approach

Merges will happen in several phases based on where each repo sits in the overall dependency graph of Lit-related things.

This repo will be in phase: 2 of 10

Since this repo is in a downstream phase, its dependency versions that use Lit 3 haven't released yet, so its CI will be in a broken state. This will be resolved when the previous phase of upgrades completes.

Next steps

  • CODEOWNERS approvals received 👍 (you can do that now to avoid holding up the upgrade later!)
  • Wait until this repo's phase of the upgrade arrives ⌛
  • Rebase from main / master to pick up latest changes
  • If this repo has a package-lock.json, update to latest dependencies
  • CI goes green ✅
  • Merge & trigger a MAJOR version bump

@dlockhart dlockhart requested a review from a team May 3, 2024 18:43
@dlockhart dlockhart marked this pull request as ready for review May 21, 2024 18:35
@dlockhart dlockhart merged commit 2edae72 into main May 21, 2024
1 check passed
@dlockhart dlockhart deleted the GAUD-6342/lit-3 branch May 21, 2024 18:35
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant