Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable the component #49

Open
zwilson2 opened this issue Jul 27, 2017 · 3 comments
Open

Ability to disable the component #49

zwilson2 opened this issue Jul 27, 2017 · 3 comments

Comments

@zwilson2
Copy link

In the case where it takes time to process the file, the user may want to disable the file upload control until the processing is complete.

@dbatiste
Copy link
Contributor

I think there should be better integration between the UI (file input) and the upload. I don't think the consuming code of this component should be left to manage the state (for example, while uploading, in the event of errors, etc.).

@zwilson2
Copy link
Author

I'm not just talking while this component is processing the file though. Our FRA takes the uploaded file and pushes it to S3 which can be a fairly lengthy process depending on how large the file is. This component wouldn't be aware that the S3 upload is happening so our component that wraps this would need to be able to control the disabled state.

@dbatiste
Copy link
Contributor

Yep. I think the application code should not be acting as the controller between the file upload and the file input. There's a whole bunch of scenarios that can come up related to upload (to S3 or where ever) that potentially affect the state of the UI, and we don't want the app code to know about all of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants