D2L0102: Attemped to locate an unlocatable type #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omsmith
commented
Sep 22, 2023
Comment on lines
+105
to
+107
| new( "D2L.LP.Extensibility.Activation.Domain.SingletonLocator", "Get", _ => true, m => m.TypeArguments.Single() ), | ||
| new( "D2L.LP.Extensibility.Activation.Domain.IServiceLocator", "Get", m => m.TypeParameters.Length == 1, m => m.TypeArguments.Single() ), | ||
| new( "D2L.LP.Extensibility.Activation.Domain.IServiceLocator", "TryGet", m => m.TypeParameters.Length == 1, m => m.TypeArguments.Single() ), |
There was a problem hiding this comment.
Should perhaps add IObjectActivator as well?
There was a problem hiding this comment.
I'm wondering why this is in D2L.CodeStyle vs the spot for analyzers in the LMS repo?
I don't really care, just want to understand where/if we draw the line.
There was a problem hiding this comment.
Was simply putting it beside the other locator analyzers. Would be happy if they all moved. Would need to rewrite / port spectests in that case though.
There was a problem hiding this comment.
Spec tests in the LMS repo are probably a good idea.
Anyway no worries, just wondering.
omsmith
changed the title
j3parker
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Unlocatable] and [Unlocatable.Candidate] analyzer