-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm "async" anywhere from IAsyncEnumerable & methods returning it #905
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c39e113
Add a test for desired behaviour
AnaCoda 2bd09b8
Create new specific test for IAsyncEnumerator and implement generator
AnaCoda 9a99967
More accurate MethodReturningIAsyncEnumerator
AnaCoda 847ca0a
Remove redundant comment
AnaCoda a322c46
Transform only function name and not parameters, and add test for it
AnaCoda a40f79b
Remove impossible non-generic return
AnaCoda 3d308fc
Fix IAsyncEnumer(ator)(able) mistakes and add using System.Collection…
AnaCoda 18d5590
Check for namespace name
AnaCoda aa1139a
Optional param for test completeness
08710c5
Check full return type for IAsyncEnumerable in invocation expressions
AnaCoda 2b5fb05
Merge branch 'anacoda/handle-iasyncenumerable' of https://github.com/…
AnaCoda d0f9101
Use member flag in RemoveAsyncSuffix instead of WithExpression
AnaCoda a5ca8cd
Merge branch 'main' into anacoda/handle-iasyncenumerable
9501d2f
(re)store previous m_removeAsyncAnywhere state
AnaCoda cbf40f7
Use try finally to restore m_removeAsyncAnywhere in any case
AnaCoda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this check
optional
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, because there are cases where a function may return IAsyncEnumerable and not end in Async and we want the sync generator to transform it without a diagnostic