D2L0017: Drop diagnostic. Migrated to D2L.Lms.Analyzers (#949)

Brightspace · Apr 25, 2024 · b60f530 · b60f530
1 parent 5c0e2d7
commit b60f530
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 260 deletions.
diff --git a/src/D2L.CodeStyle.Analyzers/ApiUsage/ServiceLocator/SingletonLocatorAnalyzer.cs b/src/D2L.CodeStyle.Analyzers/ApiUsage/ServiceLocator/SingletonLocatorAnalyzer.cs
diff --git a/src/D2L.CodeStyle.Analyzers/Diagnostics.cs b/src/D2L.CodeStyle.Analyzers/Diagnostics.cs
@@ -65,16 +65,7 @@ public static class Diagnostics {
 
 		// Retired:
 		// D2L0014 (SingletonIsntImmutable): "Classes marked as a singleton should be immutable.",
-
-		public static readonly DiagnosticDescriptor SingletonLocatorMisuse = new DiagnosticDescriptor(
-			id: "D2L0017",
-			title: "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute",
-			messageFormat: "Cannot use OldAndBrokenSingletonLocator to inject {0} because it lacks the [Singleton] attribute",
-			category: "Correctness",
-			defaultSeverity: DiagnosticSeverity.Error,
-			isEnabledByDefault: true,
-			description: "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute."
-		);
+		// D2L0017 (SingletonLocatorMisuse): "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute"
 
 		public static readonly DiagnosticDescriptor DangerousMethodsShouldBeAvoided = new DiagnosticDescriptor(
 			id: "D2L0018",

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/SingletonLocatorAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/SingletonLocatorAnalyzer.cs