Make spec tests use analyzers fully qualified name (#953)

This will help split this repo up into separate packages with embedded analyzers.
Brightspace · Aug 7, 2024 · 907b8cc · 907b8cc
1 parent aaa1ced
commit 907b8cc
Show file tree

Hide file tree

Showing 34 changed files with 34 additions and 37 deletions.
diff --git a/src/D2L.CodeStyle.SpecTests/SpecTestFixtureBase.cs b/src/D2L.CodeStyle.SpecTests/SpecTestFixtureBase.cs
@@ -98,7 +98,7 @@ private DiagnosticAnalyzer GetAnalyzerNameFromSpec( string source ) {
 
 			string analyzerName = headerContents.Substring( "analyzer: ".Length ).Trim();
 
-			var type = Type.GetType( analyzerName + ", D2L.CodeStyle.Analyzers" );
+			var type = Type.GetType( analyzerName );
 
 			Assert.NotNull( type, "couldn't get type for analyzer {0}", analyzerName );
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/AttributeAliasesAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/AttributeAliasesAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.AttributeAliasesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.AttributeAliasesAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/AwaitedTasksAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/AwaitedTasksAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.AwaitedTasksAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.AwaitedTasksAnalyzer, D2L.CodeStyle.Analyzers
 
 using System.Threading.Tasks;
 using System.Runtime.CompilerServices;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/BlockingAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/BlockingAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Async.BlockingAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Async.BlockingAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Threading.Tasks;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ClassShouldBeSealedAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ClassShouldBeSealedAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.ClassShouldBeSealedAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.ClassShouldBeSealedAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.CodeStyle.Analyzers.Specs {
 	// no diagnostic because they're public

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConfigViewerAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConfigViewerAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Configs.ConfigViewerAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Configs.ConfigViewerAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.Configuration.Config.Domain {
 	public interface IConfigViewer {

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConsistentParameterAttributesAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConsistentParameterAttributesAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ConsistentParameterAttributesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ConsistentParameterAttributesAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.CodeStyle.Annotations.Contract

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConstantAttributeAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ConstantAttributeAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ConstantAttributeAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ConstantAttributeAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/D2LPageAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/D2LPageAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.D2LPageAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.D2LPageAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.Web
 {

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/DangerousMemberUsagesAnalyzer.DangerousMethods.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/DangerousMemberUsagesAnalyzer.DangerousMethods.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DangerousMemberUsages.DangerousMemberUsagesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DangerousMemberUsages.DangerousMemberUsagesAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Reflection;

diff --git a/...s/D2L.CodeStyle.Analyzers.Test/Specs/DangerousMemberUsagesAnalyzer.DangerousProperties.cs b/...s/D2L.CodeStyle.Analyzers.Test/Specs/DangerousMemberUsagesAnalyzer.DangerousProperties.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DangerousMemberUsages.DangerousMemberUsagesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DangerousMemberUsages.DangerousMemberUsagesAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/DefaultValueConsistencyAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/DefaultValueConsistencyAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.DefaultValueConsistencyAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.DefaultValueConsistencyAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace ThingThatShouldntCrash {
 	public void FunctionOutOfPlace( int arg = 3 );

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventHandlerLoaderTypesAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventHandlerLoaderTypesAnalyzer.cs
@@ -1,5 +1,4 @@
-
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventHandlerLoaderTypesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventHandlerLoaderTypesAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.Distributed.Events.Domain {
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventHandlersDisallowedListAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventHandlersDisallowedListAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventHandlersDisallowedListAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventHandlersDisallowedListAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.Distributed.Events.ExternalPublish.UserInteraction {
 	public sealed class UserInteractionEvent { }

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventPublisherEventTypesAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventPublisherEventTypesAnalyzer.cs
@@ -1,5 +1,4 @@
-
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventPublisherEventTypesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventPublisherEventTypesAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.Distributed.Events.Domain {
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventTypesAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/EventTypesAnalyzer.cs
@@ -1,5 +1,4 @@
-
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventTypesAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Events.EventTypesAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.Distributed.Events.Domain {
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ExplicitCancellationTokenArgumentAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ExplicitCancellationTokenArgumentAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Async.ExplicitCancellationTokenArgumentAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Async.ExplicitCancellationTokenArgumentAnalyzer, D2L.CodeStyle.Analyzers
 
 using System.Threading;
 using System.Threading.Tasks;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/FeatureDefinitionAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/FeatureDefinitionAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.LaunchDarkly.FeatureDefinitionAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.LaunchDarkly.FeatureDefinitionAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.LP.LaunchDarkly {
 	public abstract class FeatureDefinition<TValue> { }

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutabilityAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutabilityAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Collections.Generic;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutabilityAnalyzer_TypeArguments.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutabilityAnalyzer_TypeArguments.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Collections.Generic;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutableCollectionsAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ImmutableCollectionsAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.SystemCollectionsImmutable.ImmutableCollectionsAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.SystemCollectionsImmutable.ImmutableCollectionsAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Collections.Generic;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/InterfaceBinderAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/InterfaceBinderAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DataRecordConverters.InterfaceBinderAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.DataRecordConverters.InterfaceBinderAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.LP.Serialization;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/JsonParamBinderAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/JsonParamBinderAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.JsonParamBinderAttribute.JsonParamBinderAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.JsonParamBinderAttribute.JsonParamBinderAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.CodeStyle.Analyzers.ApiUsage.JsonParamBinderAttribute;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/NoAsyncFuncsAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/NoAsyncFuncsAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.NoAsyncFuncsAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.NoAsyncFuncsAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Runtime.CompilerServices;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/OldAndBrokenServiceLocatorAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/OldAndBrokenServiceLocatorAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ServiceLocator.OldAndBrokenServiceLocatorAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.ServiceLocator.OldAndBrokenServiceLocatorAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.LP.Extensibility.Activation.Domain;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/OnlyVisibleToAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/OnlyVisibleToAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.OnlyVisibleToAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.OnlyVisibleToAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ReadOnlyParameterAnalyzerSpec.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ReadOnlyParameterAnalyzerSpec.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Immutability.ReadOnlyParameterAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Immutability.ReadOnlyParameterAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/ReflectionSerializerAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/ReflectionSerializerAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Serialization.ReflectionSerializerAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Serialization.ReflectionSerializerAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.LP.Serialization;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/RequireNamedArgumentsAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/RequireNamedArgumentsAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.RequireNamedArgumentsAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.RequireNamedArgumentsAnalyzer, D2L.CodeStyle.Analyzers
 
 using D2L.CodeStyle.Annotations.Contract;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/RpcAnalyzer.NoDependencyAttribute.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/RpcAnalyzer.NoDependencyAttribute.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.RpcAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.RpcAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 namespace D2L.Web {

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/RpcAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/RpcAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.RpcAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.RpcAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using System.Collections.Generic;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/SerializerAttributeAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/SerializerAttributeAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Serialization.SerializerAttributeAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.ApiUsage.Serialization.SerializerAttributeAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 using D2L.LP.Serialization;

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/StatelessFuncAnalyzerSpec.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/StatelessFuncAnalyzerSpec.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Immutability.StatelessFuncAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Immutability.StatelessFuncAnalyzer, D2L.CodeStyle.Analyzers
 
 using System;
 

diff --git a/tests/D2L.CodeStyle.Analyzers.Test/Specs/StructShouldBeReadonlyAnalyzer.cs b/tests/D2L.CodeStyle.Analyzers.Test/Specs/StructShouldBeReadonlyAnalyzer.cs
@@ -1,4 +1,4 @@
-// analyzer: D2L.CodeStyle.Analyzers.Language.StructShouldBeReadonlyAnalyzer
+// analyzer: D2L.CodeStyle.Analyzers.Language.StructShouldBeReadonlyAnalyzer, D2L.CodeStyle.Analyzers
 
 namespace D2L.CodeStyle.Analyzers.Specs.Good {