Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from yapf to ruff #418

Merged
merged 8 commits into from
Sep 8, 2024
Merged

Transition from yapf to ruff #418

merged 8 commits into from
Sep 8, 2024

Conversation

Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Sep 4, 2024

This PR switches the project to use ruff for the project. It seems to be much faster and more configurable, so I think this is a nice quality of life improvement.

Breakthrough and others added 2 commits July 7, 2024 18:37
…in the github_actions group across 1 directory (#417)

Bump actions/download-artifact

Bumps the github_actions group with 1 update in the /.github/workflows directory: [actions/download-artifact](https://github.com/actions/download-artifact).


Updates `actions/download-artifact` from 3 to 4.1.7
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
scenedetect/_cli/context.py Dismissed Show dismissed Hide dismissed
scenedetect/backends/pyav.py Dismissed Show dismissed Hide dismissed
@Breakthrough Breakthrough changed the base branch from main to develop September 5, 2024 02:51
wjs018
wjs018 previously approved these changes Sep 5, 2024
@wjs018
Copy link
Collaborator

wjs018 commented Sep 5, 2024

I am going to have to get this set up on my end, but it looks like there is a nice native way to do this in VSCode and all the formatting options are set in pyproject.toml. So, I don't think this will be too problematic.

@Breakthrough Breakthrough merged commit 4575d5a into develop Sep 8, 2024
32 checks passed
Breakthrough added a commit that referenced this pull request Sep 8, 2024
* [cli] Fix SyntaxWarning due to incorrect escaping #400

* [cli] Fix exception when detect-hash is set as default detector

* [cli] Fix new detectors not working with default-detector

* [cli] Fix outstanding CodeQL lint warnings.

* [cli] Unify type hints and clean up imports

* add detect-hash and detect-hist as options for default-detector (#403)

* Bump jinja2 from 3.1.3 to 3.1.4 in /website (#397)

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.3...3.1.4)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [dist] Fix Github license detection.

* [dist] Use Github license template. Fixes #365.

* [docs] Add CITATION.cff #399

* [dist] Prepare for v0.6.4 release.

* [build] Auto-generate .version_info and verify installer version.

* [build] Add missing pre-release script invocation for Windows build on Github.

* [build] Fix incorrect path to pre_release script.

* [build] Omit unnecessary files in distributed docs.

* [dist] Update Windows installer for v0.6.4.

Bump OpenCV to 4.10.

* [build] Use specific OpenCV version for Windows build.

* [dist] Release v0.6.4.

* [docs] Update changelog and image URI.

* add detect-hash and detect-hist as options for default-detector

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Breakthrough <[email protected]>

* [dist] Prepare changelog for next release.

* [project] Switch from yapf to ruff for formatting

* [project] Use ruff for linting project

Now passes `ruff check` with some fixes suppressed.

* [project] Enable more lint rules.

* [docs] Change single quotes to double quotes.

* Transition from yapf to ruff (#418)

* [project] Enable more lint rules.

* Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows in the github_actions group across 1 directory (#417)

Bump actions/download-artifact

Bumps the github_actions group with 1 update in the /.github/workflows directory: [actions/download-artifact](https://github.com/actions/download-artifact).


Updates `actions/download-artifact` from 3 to 4.1.7
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [build] Fix incorrect version conversion for Pyinstaller build

* [build] Update workflow actions.

* [build] Update workflow actions.

* Revert "[build] Update workflow actions."

Mistaken merge commit. This reverts commit c23eee8.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: moritzbrantner <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Breakthrough Breakthrough deleted the develop-yapf-to-ruff branch September 8, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants