Fixes io_uring permission error in Docker. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`io_uring_enter`, `io_uring_register`, and `io_uring_setup` were taken out of the Docker default seccomp profile (see moby/moby@891241e). This caused our tests to fail with `permission denied` when calling any of those system calls during `docker compose build tested`. This commit changes our seccomp profile to unconfined and runs our containers as privileged. Also, since images can only be built with the default profile, we can no longer run our tests during image build time. They are now run as a container command.
jasone
approved these changes
Jun 28, 2024
| USER hemlock | ||
| WORKDIR /home/hemlock/Hemlock/bootstrap | ||
| RUN find . -type f -regex '.*\mli?' | xargs -- opam exec -- ocp-indent -i \ | ||
| CMD find . -type f -regex '.*\mli?' | xargs -- opam exec -- ocp-indent -i \ |
There was a problem hiding this comment.
Hah, s/RUN/CMD/ is the part I couldn't figure out from the docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_uring_enter,io_uring_register, andio_uring_setupwere taken out of the Docker default seccomp profile (seemoby/moby@891241e). This caused our tests to fail with
permission deniedwhen calling any of those system calls duringdocker compose build tested.This commit changes our seccomp profile to unconfined and runs our containers as privileged. Also, since images can only be built with the default profile, we can no longer run our tests during image build time. They are now run as a container command.