use [] to access objects

BranchMetrics · Apr 7, 2019 · 04dcd0d · 04dcd0d
1 parent 578202c
commit 04dcd0d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/1_utils.js b/src/1_utils.js
@@ -952,16 +952,6 @@ utils.removePropertiesFromObject = function(objectToModify, keysToRemove) {
 	}
 };
 
-utils.getPropertyValueByNameFromObj = function(objectToSearch, name) {
-	if (objectToSearch && typeof objectToSearch === "object") {
-		for (var key in objectToSearch) {
-			if (objectToSearch.hasOwnProperty(key) && key===name) {
-				return objectToSearch[key];
-			}
-		}
-	}
-}
-
 // v2/event utility functions
 
 var BRANCH_STANDARD_EVENTS = [ 'ADD_TO_CART', 'ADD_TO_WISHLIST', 'VIEW_CART', 'INITIATE_PURCHASE', 'ADD_PAYMENT_INFO', 'PURCHASE', 'SPEND_CREDITS', 'SEARCH', 'VIEW_ITEM', 'VIEW_ITEMS', 'RATE', 'SHARE', 'COMPLETE_REGISTRATION', 'COMPLETE_TUTORIAL', 'ACHIEVE_LEVEL', 'UNLOCK_ACHIEVEMENT' ];

diff --git a/src/journeys_utils.js b/src/journeys_utils.js
@@ -439,8 +439,8 @@ journeys_utils.animateBannerEntrance = function(banner) {
 			banner.style.top = '0';
 		}
 		else if (journeys_utils.position === 'bottom') {
-			var safeAreaRequired = utils.getPropertyValueByNameFromObj(journeys_utils.journeyLinkData['journey_link_data'], 'safeAreaRequired') || false;
-			if(!safeAreaRequired) {
+			// check if safeAreaRequired is true or not
+			if (journeys_utils.journeyLinkData && journeys_utils.journeyLinkData['journey_link_data'] && !journeys_utils.journeyLinkData['journey_link_data']['safeAreaRequired']) {
 				banner.style.bottom = '0';
 			} else {
 				journeys_utils._dynamicallyRepositionBanner();