Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow file to change version #811

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

pitbull51067
Copy link
Collaborator

@pitbull51067 pitbull51067 commented Apr 16, 2024

Description

Created a workflow file to increment the version number of github depending on pushes made to the master branch.

Closes #70

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I have tested it on my private repository and also on my fork branch. I have also showed it to my peers.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Kevin-771 and others added 21 commits January 30, 2024 17:00
added some basic functions to GridRegion
Added rippleeffect folder within puzzles so we can begin implementing and rendering the demo puzzle

Added RippleEffect.java
Added RippleEffectCell.java
Added RippleEffectImporter.java
Added RippleEffectView.java
Added more dependencies for RippleEffect board
Added config for RippleEffect editing support
…Regions

# Conflicts:
#	bin/main/edu/rpi/legup/legup/config
#	src/main/java/edu/rpi/legup/model/gameboard/GridRegion.java
#	src/main/resources/edu/rpi/legup/legup/config
@charlestian23 charlestian23 changed the base branch from master to dev April 16, 2024 20:53
@charlestian23
Copy link
Collaborator

charlestian23 commented May 5, 2024

@Chase-Grajeda, I'll leave this one to you for once regions are implemented since some of the code seems to be from that. At least from a look at the YML file and the demo that was given to us in the last week of the semester, this seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants