Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAsStruct: Filter members to fields only #33

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

ArthaTi
Copy link
Contributor

@ArthaTi ArthaTi commented Jun 20, 2023

Closes #32

@BradleyChatha
Copy link
Owner

Nice, cheers for that.

Would you mind writing up a quick unittest for this fix? If not then I can do it at some point :)

@ArthaTi
Copy link
Contributor Author

ArthaTi commented Jun 21, 2023

Sure enough, I'll try to make one whenever I can.

@ArthaTi
Copy link
Contributor Author

ArthaTi commented Jun 22, 2023

There we go. I think it might be a good idea to add more unittests for this. I've also encountered issues with delegates; I think the context passed to delegates gets broken, and documentation only seems to cover context-less delegates, but that probably deserves its own issue.

It might be relevant, so I've recently learnt of mir.ion, maybe it could be possible to integrate it to handle metaprogramming and attributes automatically.

@BradleyChatha
Copy link
Owner

Nice, thanks for that.

Yeah, generally I accept that this library is poorly tested but I find I've found it really hard this year to motivate myself to do much with/in D.

The delegate stuff is super jank as you've noticed, definitely requires a bit more looking into (however, due to what I mentioned above, it's probably gonna be like this for a while :/ )

mir.ion is really cool. I do wonder if it's appropriate to integrate directly with it in this library or not though. Could definitely add it as an optional feature though via a version(XXX) guard.

Either way, this MR looks good to go, I'll get it merged and tagged so it can start being used in dub ASAP.

@BradleyChatha BradleyChatha merged commit e9d23d6 into BradleyChatha:master Jun 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants