-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hardware wallet support #684
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5a4b3a4
to
3401d8d
Compare
3401d8d
to
f76c5b8
Compare
Then again this one, want me to enable blind signing to continue? @michael1011 |
PS: Ethereum App Version is 1.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nano S shows in Browser's HID device list and I can select it but no matter how I try to connect it to Boltz Web App (RSK testnet derivation path on testnet deployment or ETH/RSK derivation path on mainnet deployment) everything fails with Wallet connection failed: Failed to open the device.
No matter if with an app open or none open. Device is connected and unlocked and works fine with e.g. Ledger Live.
a67c734
to
3bf8182
Compare
That's done. Regtest shows all
Reload the page and/or plug in the device again. Nothing we can do about this flakiness |
3d925e7
to
fbce2a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Submarine Swaps (Chromium, no Metamask or other Web3 wallet installed) I get this when pressing "Connect to swap address", it doesn't open the ledger/trezor dialogue.
For Reverse Swaps the connection prompt comes up but still "fails to open device", just like in my review from last week. above The browser HIW recognized my nano s and I connected it beforehand.
Both tested on Testnet and Mainnet.
Closes #680
Closes #681
We should lazy load the LedgerSigner, because its dependencies are heavy
@kilrau needs translations