feat: hardware wallet support

[michael1011]

Closes #680
Closes #681

We should lazy load the LedgerSigner, because its dependencies are heavy

@kilrau needs translations

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
webapp	✅ Ready (Inspect)	Visit Preview	Oct 21, 2024 0:26am
webapp-mainnet	✅ Ready (Inspect)	Visit Preview	Oct 21, 2024 0:26am

[kilrau]

My nano s is connected and unlocked (it's recognized by Ledger Live and also Sparrow) but can't click "Ledger". What am I missing?

EDIT: seems to be a FF issue (missing WebHID). So the ledger button should throw sth like "Browser not supported" when clicking

[kilrau]

If the wrong (not Ethereum/RSK) app open on Ledger it throws


Error should say "Please open Ethereum/RSK app on your Ledger"

[kilrau]

If no app open at all - Ledger doesn't show in the dialogue. I bet some users wouldn't know why. I would always bring up this menu with ALL available options (Trezor, Ledger, Metamask) so that you can throw proper errors when clicking them (never disable click but throw "No Trezor wallet connected":

It's common UX to bring up a "select wallet" menu

[kilrau]

Hmm soo connecting (which prompts me to open the ethereum app on my ledger) sometimes work sometimes hangs in this state forever (ethereum app on ledger is open):

and then when refreshing and trying to connect again throws:

[kilrau]

Also, when I "disconnect" "Create Atomic Swap button is still enabled and let's me create the swap. It should be disabled. Now I am in a state where claiming my swap doesn't work because ledger is disconnected. As this can happen for other reasons too, this claiming step needs a "connect" button if the wallet is disconnected.

EDIT: when refreshing it switches to "connect to swap address". Hmm maybe we can hint on the refresh?

[kilrau]

I connected my ledger again then it was hanging in this state without continuing

[kilrau]

Then I refreshed, connected to swap address again, pressed continue and then this one

My ledger showing Error: Blind signing must be enabled in settings which makes sense as I never used this Ledger for Ethereum transactions before but Web App needs to catch this error and show this properly:

[kilrau]

Refreshing, again hanging here not succeeding to connect

I tried several times no luck, always closing Ethereum app on my ledger before refreshing the site so that it prompted me to open it (which I did). When leaving Ethereum App open, refreshing - it finally succeeded. I reproduced several more times: when I have Ethereum app closed and Ledger prompts me to open it, Boltz Web App hangs.

[kilrau]

Then again this one, want me to enable blind signing to continue? @michael1011

[kilrau]

PS: Ethereum App Version is 1.12.1

[kilrau]

Blind signing works now, but please hint me to look at my ledger and choose "accept risk and sign"

[kilrau]

Ethereum app on Ledger crashed twice and I had to retry but finally made it:

[kilrau]

above

[kilrau]

good

[kilrau]

Now I can't make my nano s to appear in the HID list at all. No matter if with ethereum app open or not. I think I'll leave it be for today.

[kilrau]

Nano S shows in Browser's HID device list and I can select it but no matter how I try to connect it to Boltz Web App (RSK testnet derivation path on testnet deployment or ETH/RSK derivation path on mainnet deployment) everything fails with Wallet connection failed: Failed to open the device. No matter if with an app open or none open. Device is connected and unlocked and works fine with e.g. Ledger Live.

[michael1011]

On Testnet only show derivation path of Testnet. Mainnet doesn't display Testnet - all good.

That's done. Regtest shows all

No matter if with an app open or none open. Device is connected and unlocked and works fine with e.g. Ledger Live.

Reload the page and/or plug in the device again. Nothing we can do about this flakiness

[kilrau]

For Submarine Swaps (Chromium, no Metamask or other Web3 wallet installed) I get this when pressing "Connect to swap address", it doesn't open the ledger/trezor dialogue.

For Reverse Swaps the connection prompt comes up but still "fails to open device", just like in my review from last week. above The browser HIW recognized my nano s and I connected it beforehand.

Both tested on Testnet and Mainnet.

[kilrau]

With Brave USB connection works pretty well. Some more feedback: if I don't have any app open (not every time but quite often) I get web app into the state where it loads the derivation path infinitely. Also happens if derivation path select menu (ETH vs RSK) came up and I have my ETH app open. It just keeps loading. Refresh web app, do it again and it works.