feat: play sound on successful swaps #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice, but it should play independently from notifications, just like mempool.space |
|
Don't have "Play sound". Just play it when one enables it via the toggle. Also, please try a toggle style without writing "on/off" out. Or at least only one of them. These toggles were invented to signify on/off... Also on right, off left seems to be standard these days |
michael1011
requested changes
May 17, 2024
michael1011
requested changes
May 17, 2024
closes #338 Update src/context/Global.tsx Co-authored-by: michael1011 <[email protected]>
|
translations look good |
michael1011
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not very happy with the sound still, hard to find a good one
closes #338