Always saves notification for user

Board-of-Directors · Nov 7, 2023 · 2db2857 · 2db2857
1 parent 62bc2c6
commit 2db2857
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/main/java/ru/nsu/fit/directors/userservice/service/NotificationServiceImpl.java b/src/main/java/ru/nsu/fit/directors/userservice/service/NotificationServiceImpl.java
@@ -32,16 +32,15 @@ public class NotificationServiceImpl implements NotificationService {
     @Override
     public void handleOrderNotification(OrderNotificationEvent event) {
         User user = userRepository.findById(event.userId()).orElseThrow();
-        if (user.getVkUserId() != null) {
-            try {
+        try {
+            if (user.getVkUserId() != null) {
                 vkApi.sendNotification(
                     new RequestVkNotification(event.message(), vkServiceKey, String.valueOf(user.getVkUserId()))
                 );
-            } catch (Exception e) {
-                saveNotification(event, user);
-                log.error(e.getMessage());
             }
-        } else {
+        } catch (Exception e) {
+            log.error(e.getMessage());
+        } finally {
             saveNotification(event, user);
         }
     }