Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4969 // Open tagged resources in studios #1543

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Sep 16, 2024

Fixes #4969

Description

Resources with query params like rev or tag in their self were not opening in studios. This pr formats the query param correctlu

How has this been tested?

I've added tests for resources with self containing tag, revision, both, or neither

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika changed the base branch from main to develop September 16, 2024 09:40
@Dinika Dinika force-pushed the 4969-open-tagged-res-in-studios branch from 49d7e6d to edf8cfb Compare September 16, 2024 09:41
@Dinika Dinika changed the title 4969 open tagged res in studios 4969 // Open tagged resources in studios Sep 16, 2024
@Dinika Dinika force-pushed the 4969-open-tagged-res-in-studios branch from edf8cfb to 371fba0 Compare September 16, 2024 11:36
@Dinika Dinika force-pushed the 4969-open-tagged-res-in-studios branch from 371fba0 to 2dd7412 Compare September 16, 2024 11:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.16%. Comparing base (738cb9c) to head (8255200).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
+ Coverage    48.00%   48.16%   +0.15%     
===========================================
  Files          252      252              
  Lines        11576    11578       +2     
  Branches      2714     2861     +147     
===========================================
+ Hits          5557     5576      +19     
+ Misses        5986     5965      -21     
- Partials        33       37       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika merged commit 0932d7e into develop Sep 16, 2024
1 check passed
@Dinika Dinika deleted the 4969-open-tagged-res-in-studios branch September 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants