Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F4087: Add download by clicking on the icon on tooltip #1350

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

bilalesi
Copy link
Contributor

f-4087/update: enhance key binding style

Fixes #BlueBrain/nexus#4087

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

f-4087/update: enhance key binding style
@bilalesi bilalesi requested a review from smitfire July 25, 2023 14:49
@bilalesi bilalesi self-assigned this Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1350 (243ff74) into develop (1a6d489) will decrease coverage by 0.04%.
Report is 43 commits behind head on develop.
The diff coverage is 65.64%.

@@             Coverage Diff             @@
##           develop    #1350      +/-   ##
===========================================
- Coverage    47.76%   47.73%   -0.04%     
===========================================
  Files          241      243       +2     
  Lines        10714    10734      +20     
  Branches      2505     2523      +18     
===========================================
+ Hits          5118     5124       +6     
- Misses        5564     5578      +14     
  Partials        32       32              
Files Changed Coverage Δ
...red/components/ResourceEditor/useEditorTooltip.tsx 3.50% <0.00%> (-1.10%) ⬇️
src/subapps/dataExplorer/ProjectSelector.tsx 96.96% <ø> (ø)
...rc/shared/components/ResourceEditor/editorUtils.ts 18.08% <19.23%> (+0.69%) ⬆️
src/subapps/dataExplorer/PredicateSelector.tsx 96.52% <50.00%> (+0.02%) ⬆️
src/utils/validUrl.ts 38.46% <50.00%> (ø)
...pps/dataExplorer/DataExplorerCollapsibleHeader.tsx 98.21% <98.21%> (ø)
...as/DataExplorerGraphFlow/DateExplorerGraphFlow.tsx 94.64% <100.00%> (+0.76%) ⬆️
src/shared/components/Icons/FilterIcon.tsx 100.00% <100.00%> (ø)
...rc/shared/components/ResourceEditor/CodeEditor.tsx 100.00% <100.00%> (ø)
src/shared/components/ResourceEditor/index.tsx 16.82% <100.00%> (-0.26%) ⬇️
... and 4 more

... and 72 files with indirect coverage changes

@bilalesi bilalesi merged commit 243ff74 into develop Jul 28, 2023
1 check passed
@bilalesi bilalesi deleted the f-4087/simplify-file-download branch July 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants