Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: file download #1346

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Hotfix: file download #1346

merged 2 commits into from
Jul 25, 2023

Conversation

bilalesi
Copy link
Contributor

Description

The contentUrl for distribution has been changed to an encoded format (not all the projects)
so to be sure that the resource can be resolved for download we have to make sure that the resource is encoded

  1. Decode the contentUrl and re-encode it again to be sure that the url is encoded.
  2. Use _self when possible since the _self is resolvable.
  3. remove the revision if it exists in files (Resolvers can not resolve when revision is present)

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

…solve the file

fix: use _self when possible

fix: remove version from files to be able to resolve by the resolver
@bilalesi bilalesi requested a review from smitfire July 25, 2023 10:52
@bilalesi bilalesi self-assigned this Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1346 (1aeacce) into develop (1a6d489) will increase coverage by 0.02%.
The diff coverage is 64.00%.

@@             Coverage Diff             @@
##           develop    #1346      +/-   ##
===========================================
+ Coverage    47.76%   47.79%   +0.02%     
===========================================
  Files          241      242       +1     
  Lines        10714    10708       -6     
  Branches      2505     2515      +10     
===========================================
  Hits          5118     5118              
+ Misses        5564     5558       -6     
  Partials        32       32              
Files Changed Coverage Δ
...rc/shared/components/ImagePreview/ImagePreview.tsx 13.51% <ø> (ø)
src/shared/components/Preview/Preview.tsx 36.24% <ø> (ø)
...red/components/ResourceEditor/useEditorTooltip.tsx 3.80% <0.00%> (-0.80%) ⬇️
...components/ResourceEditor/useResolutionActions.tsx 31.25% <ø> (ø)
...tainers/AnalysisPlugin/AnalysisPluginContainer.tsx 49.31% <ø> (ø)
src/shared/containers/ResourceActionsContainer.tsx 20.89% <0.00%> (-2.30%) ⬇️
src/shared/containers/TableViewerContainer.tsx 37.50% <ø> (ø)
src/subapps/dataExplorer/ProjectSelector.tsx 96.96% <ø> (ø)
...subapps/admin/components/Settings/ViewsSubView.tsx 17.82% <12.90%> (-1.46%) ⬇️
...red/components/ResourceEditor/ResourcesLRUCache.ts 31.81% <16.66%> (-5.69%) ⬇️
... and 12 more

... and 62 files with indirect coverage changes

@bilalesi bilalesi merged commit 007d26e into develop Jul 25, 2023
1 check passed
@bilalesi bilalesi deleted the hotfix/file-download branch July 25, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants