Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Anchor icon path #1333

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Hotfix: Anchor icon path #1333

merged 2 commits into from
Jul 17, 2023

Conversation

bilalesi
Copy link
Contributor

Fixes #

Description

the anchor link icon in the JSON editor seems not showed correctly due the import url

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi requested a review from Dinika July 17, 2023 09:28
@bilalesi bilalesi self-assigned this Jul 17, 2023
@Dinika
Copy link
Contributor

Dinika commented Jul 17, 2023

seems to be working for me locally. Don't know how we missed this 😞 Since the icon is in css, testing would not catch it. We could either do a screenshot test to catch this in future or add the icon in the javascript (the icon could be a simple, presentational icon, although I think it might make sense to make it clickable too) and add a simple test to check they exist.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #1333 (574199d) into develop (669935c) will not change coverage.
The diff coverage is n/a.

❗ Current head 574199d differs from pull request most recent head 9805f93. Consider uploading reports for the commit 9805f93 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1333   +/-   ##
========================================
  Coverage    47.68%   47.68%           
========================================
  Files          241      241           
  Lines        10667    10667           
  Branches      2489     2489           
========================================
  Hits          5087     5087           
  Misses        5549     5549           
  Partials        31       31           

@bilalesi bilalesi merged commit 10b5e48 into develop Jul 17, 2023
1 check passed
@bilalesi bilalesi deleted the hotfix/anchor-icon-path branch July 17, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants