4042 // Enable sorting of columns #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## us-4023/reset-predicate #1328 +/- ##
===========================================================
- Coverage 47.73% 46.97% -0.77%
===========================================================
Files 241 237 -4
Lines 10681 10630 -51
Branches 2497 2492 -5
===========================================================
- Hits 5099 4993 -106
- Misses 5551 5605 +54
- Partials 31 32 +1
|
bilalesi
approved these changes
Jul 17, 2023
Comment on lines
+118
to
+122
| sorter: (a, b) => { | ||
| return JSON.stringify(a[colName] ?? '').localeCompare( | ||
| JSON.stringify(b[colName] ?? '') | ||
| ); | ||
| }, |
There was a problem hiding this comment.
I don't know it's just a thought,
I think comparing projects will be more useful only to test the project part not the org part
so instead comparing org/project will only compare project
Dinika
force-pushed
the
us-4023/reset-predicate
branch
from
d0ef42d
to
c1509c5
Compare
Dinika
force-pushed
the
us-4042/enable-column-sort
branch
from
2e6315f
to
de77b08
Compare
Signed-off-by: Dinika Saxena <[email protected]>
Signed-off-by: Dinika Saxena <[email protected]>
Dinika
force-pushed
the
us-4042/enable-column-sort
branch
from
e5a82a0
to
c3e2e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1327
sorting.mp4
Adds basic sorting to all columns.
How has this been tested?
Types of changes
Checklist: