[REP-91] Avoid raising exception when point process is missing in a section #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
Oct 23, 2024
|
Logfiles from GitLab pipeline #236489 (:white_check_mark:) have been uploaded here! Status and direct links: |
WeinaJi
previously approved these changes
Oct 23, 2024
- Avoid raising exception when point process is missing in a section
…esent in all sections to check that it doesnt raise exception
jorblancoa
force-pushed
the
jblanco/point_process_error
branch
from
3200917
to
bea41be
Compare
WeinaJi
approved these changes
Oct 30, 2024
jorblancoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Simulation was crashing when a point process was missing in a section in the context of summation reports.
Refactor the code to improve readability and avoid raising the exception to maintain consistency with CoreNEURON behavior
Review