Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy open source required doc files from branch publication/nbS1-2023 into main #20

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Aug 7, 2023

This PR is aimed for making the main branch as default.

  • Copy doc/license/banner files
  • Copy and enable the workflow script on main

@WeinaJi WeinaJi changed the title Merge branch publication/nbS1-2023 into main Copy open source required doc files from branch publication/nbS1-2023 into main Aug 8, 2023
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@WeinaJi WeinaJi marked this pull request as ready for review August 8, 2023 13:47
jorblancoa
jorblancoa previously approved these changes Aug 8, 2023
ferdonline
ferdonline previously approved these changes Aug 9, 2023
Copy link
Collaborator

@ferdonline ferdonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Noticed only possible typo. Also, I thought we would include a copyright to some mod files, did I miss them?

README.rst Outdated Show resolved Hide resolved
@WeinaJi
Copy link
Collaborator Author

WeinaJi commented Aug 9, 2023

Also, I thought we would include a copyright to some mod files, did I miss them?

Yes, it is also planned in https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-1047. But I don't know which files need a additional copy right. Do you know?

@bbpbuildbot

This comment has been minimized.

@WeinaJi WeinaJi dismissed stale reviews from ferdonline and jorblancoa via 1fab1a3 August 9, 2023 09:23
@bbpbuildbot
Copy link

Logfiles from GitLab pipeline #143001 (:white_check_mark:) have been uploaded here!

Status and direct links:

@WeinaJi
Copy link
Collaborator Author

WeinaJi commented Aug 9, 2023

Also, I thought we would include a copyright to some mod files, did I miss them?

Yes, it is also planned in https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-1047. But I don't know which files need an additional copy right. Do you know?

Or shall we merge this one first and improve the licensing in another PR? @ferdonline

@ferdonline
Copy link
Collaborator

ferdonline commented Aug 9, 2023

But I don't know which files need a additional copy right. Do you know?

I suspect it's only VecStim.mod and netstim_inhpoisson.mod from core.mod since they are the only extra ones. If that makes sense to you, maybe we can just the notice and close the topic. Later we can improve as you say
Edit: I see these files already contain some sort of copyright notice, slightly more restrictive. Without more specific instructions I think we are are good

@WeinaJi WeinaJi merged commit 8e388ba into main Aug 9, 2023
3 checks passed
@WeinaJi WeinaJi deleted the weji/main_docs branch August 9, 2023 15:34
WeinaJi added a commit that referenced this pull request Oct 14, 2024
… into main (#20)

This PR is aimed for making the `main` branch as the default branch for the repo:
* Copy doc/license/banner files
* Copy and enable the workflow script on main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants