[BBPBGLIB-1030] Reject *.sonata nodes and edges file #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If79d49a6adc370f90cd28a77f95e16abb9e4607e
Change-Id: I3a7acface7221f807cd8f2bacd3efd561eb73969
Change-Id: I8b49f48163edc2845f047cffe899b7ce1f1bfe44
Change-Id: I790ae63418688ce159486785f104006251b026d3
Change-Id: I8bf816717bfd7b89fee76579c9e58c16aa944e40
BLUECONFIGS_BRANCH=weji/sonata_files Change-Id: I150dcfec44da80671b083611f062fd7dfc5bd45c
WeinaJi
force-pushed
the
weji/reject_sonata_extension
branch
from
702c82d
to
812b43c
Compare
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #142678 (:white_check_mark:) have been uploaded here! Status and direct links: |
WeinaJi
requested review from
ferdonline and
jorblancoa
and removed request for
ferdonline
jorblancoa
approved these changes
Aug 8, 2023
ferdonline
approved these changes
Aug 9, 2023
WeinaJi
added a commit
that referenced
this pull request
Oct 14, 2024
Early in development some circuits were produced with .sonata file extension but later we decided to use .h5 extension. Currently we still have some old circuits produced with .sonata file extension. Reading wrong edge file extension (such as .sonata) could lead to a problem for registering source and destination populations of connectivity. This is because that neurodamus reads the src and dst population from the meta data ONLY for ".h5" edge files. Scope Reject *.sonata edges files, as well as nodes files. They are the same as .h5 files and should be renamed. Testing Existing unit tests and blueconfigs CI test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early in development there was some circuit data using .sonata file extension but then later we decided to use .h5 files. Currently we still have some old circuits produced with .sonata file extension. Reading wrong edge file extension (such as .sonata) could lead to a problem for registering source and destination populations of connectivity. This is because that neurodamus reads the src and dst population from the meta data ONLY for ".h5" edge files.
Scope
Reject *.sonata edges files, as well as nodes files. They are the same as .h5 files and should be renamed.
Testing
Existing unit tests and blueconfigs CI test