[BBPBGLIB-1122] Removing legacy RNGs, leaving only Random123 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration options removed
atemerev
force-pushed
the
atemerev/rng-cleanup
branch
from
244e496
to
9a1796d
Compare
This comment has been minimized.
This comment has been minimized.
atemerev
force-pushed
the
atemerev/rng-cleanup
branch
from
9a1796d
to
1ff86d3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
atemerev
force-pushed
the
atemerev/rng-cleanup
branch
from
37d19bb
to
9a1796d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #197336 (:no_entry:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing legacy RNGs and the ability to configure RNGs. Random123 is chosen everywhere as the only option.
Context
RNG types differing from Random123 are no longer used and removed from everywhere (including configuration).
Scope
RNGSettings.hoc (removed RNGmode and all related constants), configuration.py, random.py, and corresponding usages.
Testing
Write a test that raises exception in attempt to configure RNG mode.
Review