[BBPBGLIB-1110] Error now raised when executeConfigure is returned with errors

[atemerev]

Context

In the simulation config, synapse_configure contains HOC code. Neurodamus should fail fast when there is an error in configuration, instead of passing it forward.

Scope

Error check is added to connection.py

Testing

TBD

Review

• PR description is complete
• Coding style (imports, function length, New functions, classes or files) are good
• Unit/Scientific test added
• [N/A] Updated Readme, in-code, developer documentation

[jorblancoa]

Thanks for the PR!
Maybe this could be tackled in another PR, but since we are cleaning .hoc files whenever possible, maybe the ConnectionUtils.hoc could be removed and the executeConfigure() function ported to python.
At first glance it doesn't seem to be complicated. The only problematic call would be execute1(), and we could use Nd.execute1() from python.

What do you think? @WeinaJi

[WeinaJi]

Thanks for the PR! Maybe this could be tackled in another PR, but since we are cleaning .hoc files whenever possible, maybe the ConnectionUtils.hoc could be removed and the executeConfigure() function ported to python. At first glance it doesn't seem to be complicated. The only problematic call would be execute1(), and we could use Nd.execute1() from python.

What do you think? @WeinaJi

Yes, sounds good. There is already an example in https://github.com/BlueBrain/neurodamus/blob/main/neurodamus/node.py#L1152
Shall we add this python function directly in connection.py?

[jorblancoa]

Thanks for the PR! Maybe this could be tackled in another PR, but since we are cleaning .hoc files whenever possible, maybe the ConnectionUtils.hoc could be removed and the executeConfigure() function ported to python. At first glance it doesn't seem to be complicated. The only problematic call would be execute1(), and we could use Nd.execute1() from python.
What do you think? @WeinaJi

Yes, sounds good. There is already an example in https://github.com/BlueBrain/neurodamus/blob/main/neurodamus/node.py#L1152 Shall we add this python function directly in connection.py?

I think it makes sense yes

[atemerev]

Thanks for the PR! Maybe this could be tackled in another PR, but since we are cleaning .hoc files whenever possible, maybe the ConnectionUtils.hoc could be removed and the executeConfigure() function ported to python. At first glance it doesn't seem to be complicated. The only problematic call would be execute1(), and we could use Nd.execute1() from python.
What do you think? @WeinaJi

Yes, sounds good. There is already an example in https://github.com/BlueBrain/neurodamus/blob/main/neurodamus/node.py#L1152 Shall we add this python function directly in connection.py?

I think it makes sense yes

OK, so, what's the resolution? I'll delete this PR and try to work on the python port instead?

[WeinaJi]

How about continuing in the same PR to convert ConnectionUtils.hoc to Python function? You can modify the PR title and description.

[jorblancoa]

After speaking with @ferdonline, he mentioned that porting this to python would be harder than I anticipated, so we can leave it for another time!
@atemerev Forget my last comment! I think we can merge this

[atemerev]

@jorblancoa OK, let's merge then!

[bbpbuildbot]

Logfiles from GitLab pipeline #192785 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ docs
• ✅ test-unit
• ✅ test-integration
• ✅ test-integration-e2e
• ✅ test-scientific
• ✅ test-scientific-ngv
• ✅ set_alt_branches
• ✅ build-package
• ⚙️ publish-package
• ⚙️ publish-docs