-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated tests. #1011
Remove duplicated tests. #1011
Conversation
If it helps reviewing, we could split out the commits that move code, e.g. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
- Coverage 86.81% 86.40% -0.41%
==========================================
Files 100 102 +2
Lines 6081 5901 -180
==========================================
- Hits 5279 5099 -180
Misses 802 802 ☔ View full report in Codecov by Sentry. |
The new flavour of these tests, already covers all of this.
The last test for T[n][m] was already moved to `test_stl`.
2e64bb6
to
2e4a41a
Compare
Nice to split |
Interesting, I thought I'd split them out already, but yes, they can get split away too. |
There's (at least) three attempts at testing read/write cycles for multi-dimensional arrays. The first is whatever is in
tests_*multi_dims.cpp
. Since it's partial, a second attempt was made: the first half oftest_all_types.cpp
. Since this was still partial and not quite DRY enough, a third attempt was made.This PR removes the duplicated tests from the first and second attempt, one-by-one. Each commit removes one test. Or moves/reimplements a test if it's not yet covered by the third attempt.
There's a fourth attempt in
test_high_five_base.cpp
; but that's left for another PR.