Updating Undocumented #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Undocumented and Fix Component errors
DaanV2
requested changes
Aug 11, 2023
Comment on lines
7
to
13
| "properties": { | ||
| "value": { | ||
| "title": "Value", | ||
| "description": "UNDOCUMENTED.", | ||
| "type": "boolean" | ||
| } | ||
| } |
There was a problem hiding this comment.
This one need to stay for now, Microsoft uses it in their own entity:
https://learn.microsoft.com/en-us/minecraft/creator/reference/source/vanillabehaviorpack_snippets/entities/chest_minecart
There was a problem hiding this comment.
So do I just remove it, or do you? I am kinda new to this github thing.
There was a problem hiding this comment.
You removed in your code 🙂, So for this case you need to re-add it to the file 😄
There was a problem hiding this comment.
Okay, I think this is where the reply goes... I deleted my changes for is_stackable.
|
Getting confused about where comments go... anyways, deleted the is_stackable file from the PR. I think. |
DaanV2
reviewed
Aug 14, 2023
DaanV2
reviewed
Aug 14, 2023
DaanV2
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly under the Entity Components
Used information from MS-Learn component pages.