Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table inheritance not being able to find the entity metamodel #1918

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix table inheritance not being able to find the entity metamodel #1918

merged 2 commits into from
Jul 31, 2024

Conversation

EugenMayer
Copy link
Contributor

No description provided.

@EugenMayer
Copy link
Contributor Author

@beikov our test-suite was passing just fine with this fix, including the problematic part. Seems like the BP suite does pass too

@EugenMayer
Copy link
Contributor Author

@beikov any chance to get this merged? Is anything left to do?

jwgmeligmeyling
jwgmeligmeyling approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@jwgmeligmeyling jwgmeligmeyling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks obvious to me 😄

@beikov beikov merged commit 26060d5 into Blazebit:main Jul 31, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwgmeligmeyling jwgmeligmeyling jwgmeligmeyling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EugenMayer @jwgmeligmeyling @beikov