Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#841] Add json functions #1135

Merged
merged 2 commits into from
Sep 2, 2020
Merged

[#841] Add json functions #1135

merged 2 commits into from
Sep 2, 2020

Conversation

Mobe91
Copy link
Contributor

@Mobe91 Mobe91 commented Jul 20, 2020

Fixes #841

@Mobe91 Mobe91 requested a review from beikov July 20, 2020 11:06
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also missing a documentation section about the new functions and the supported JSON path syntax.

@beikov
Copy link
Member

beikov commented Jul 21, 2020

I believe this error here https://travis-ci.com/github/Blazebit/blaze-persistence/jobs/363212273#L1696 is because Oracle doesn't support grouping by a blob? Maybe we need to adapt the tests that do this.

Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please squash the whole thing

README.md Outdated Show resolved Hide resolved
entity-view/testsuite/pom.xml Show resolved Hide resolved
integration/deltaspike-data/testsuite/pom.xml Show resolved Hide resolved
integration/querydsl/testsuite/pom.xml Show resolved Hide resolved
@Mobe91 Mobe91 force-pushed the json-functions branch 2 times, most recently from 49f6eba to 56c72e9 Compare July 22, 2020 12:15
@beikov beikov merged commit 01cd3e3 into Blazebit:master Sep 2, 2020
@Mobe91 Mobe91 deleted the json-functions branch October 31, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON support functions
2 participants